[Chassis][Voq]Update sonic-buffer-queue and sonic-queue for Voq Chassis #18875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlakshm
added
Chassis 🤖
qiluo-msft
approved these changes
May 13, 2024
|
It seems that you want to add two new tables, would you please update same_config_db.json and cofiguration.md? |
|
|
||
| key "hostname asic_name port qindex"; | ||
|
|
||
|
|
There was a problem hiding this comment.
Nitpick: remove extra space
| (/sdm:sonic-device_metadata/sdm:DEVICE_METADATA/sdm:localhost/sdm:switch_type='voq')"; | ||
| key "hostname asic_name ifname qindex"; | ||
|
|
||
|
|
There was a problem hiding this comment.
nitpick: remove extra line
|
Besides the minor nitpicks, the changes look good to me. |
kenneth-arista
approved these changes
May 15, 2024
gechiang
added
the
Included in Chassis for 202205 Branch
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…is (sonic-net#18875) Why I did it The configuration for QUEUE and BUFFER_QUEUE differs between a VOQ device and a Non-VOQ devices. For the Voq device: The queue and buffer queue is applied on the system port. The system port is a representation of every port in a chassis, the key for systemport consists of Linecard Name , Asic Name and portname On a Non voq device: the queue and buffer queue configuration is applied on the front panel port. Due to this differences the yang models sonic-queue.yang and sonic-buffer-queue.yang does not work for Voq devices This is address in this PR Microsoft ADO (27252773 and 27252696): How I did it Update the yang model to have different CONFIG_LIST with different keys based on the following condition when the switch_type is not present or switch_type is not voq, the yang LIST will have key of port and queue_index when the switch_type is present and switch_type is voqhe yang LIST will have key of Linecard name, asi name, port and queue_index How to verify it UT and incremental config push on chassis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The configuration for
QUEUEandBUFFER_QUEUEdiffers between aVOQdevice and aNon-VOQdevices.For the
Voqdevice:The queue and buffer queue is applied on the system port. The system port is a representation of every port in a chassis, the key for systemport consists of
Linecard Name,Asic NameandportnameOn a Non voq device:
the queue and buffer queue configuration is applied on the front panel port.
Due to this differences the yang models
sonic-queue.yangandsonic-buffer-queue.yangdoes not work for Voq devicesThis is address in this PR
Work item tracking
How I did it
Update the yang model to have different CONFIG_LIST with different keys based on the following condition
voq, the yang LIST will have key of port and queue_indexvoqhe yang LIST will have key of Linecard name, asi name, port and queue_indexHow to verify it
UT and incremental config push on chassis
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)